Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI Revamp. #30

Merged
merged 4 commits into from
Dec 16, 2024
Merged

CLI Revamp. #30

merged 4 commits into from
Dec 16, 2024

Conversation

BrianPugh
Copy link
Collaborator

@BrianPugh BrianPugh commented Dec 16, 2024

The old CLI had some quirks that made it a bit cumbersome/odd to use when compared to standard CLI tools. This PR aims to make it more idiomatic to use.

Migration Guide/Changelog

  • Required keyword --convert with options {"c2e", e2c", "e2p"} is now positional and can be thought of as subcommands under the same names.

c2e

  • --i input path is now positional input. convert360 c2e INPUT OUTPUT
  • --o output path is now positional output. convert360 c2e INPUT OUTPUT
  • --h is now --height or -h and is (still) required.
  • --w is now --width or -w and is (still) required.
  • --format or -f now allows you to set whether the input cubemap is dice or horizon.
  • --mode now also has short option -m for setting interpolation type.

e2c

  • --i input path is now positional input. convert360 e2c INPUT OUTPUT
  • --o output path is now positional output. convert360 e2c INPUT OUTPUT
  • --h is now --height or -h and is (still) required.
  • --w is now --width or -w and is (still) required.
  • Alternative to supplying --height and --width, there is now --size -s. This is the side-length of each resulting cube face in pixels.
  • --format or -f now allows you to set whether the output cubemap should be dice or horizon.
  • --mode now also has short option -m for setting interpolation type.

e2p

  • --i input path is now positional input. convert360 e2p INPUT OUTPUT
  • --o output path is now positional output. convert360 e2p INPUT OUTPUT
  • --h_fov is now --h-fov.
  • --v_fov is now --v-fov.
  • --u_deg is now --yaw
  • --v_deg is now --pitch
  • --in_rot_deg is now --roll
  • --mode now also has short option -m for setting interpolation type.

@BrianPugh BrianPugh merged commit 0997a7d into master Dec 16, 2024
15 checks passed
@BrianPugh BrianPugh deleted the new-cli branch December 16, 2024 15:41
@BrianPugh BrianPugh mentioned this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant